Skip to content

Fix FastAPI/Starlette middleware with positional arguments. #4118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 10, 2025
Merged

Fix FastAPI/Starlette middleware with positional arguments. #4118

merged 8 commits into from
Mar 10, 2025
+26 −5

Conversation

@antonpirker
Copy link
Contributor

@antonpirker antonpirker commented Mar 5, 2025

Fixes #3246

@codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.59%. Comparing base (8672dc1) to head (63b25d9).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sentry_sdk/integrations/starlette.py 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4118      +/-   ##
==========================================
+ Coverage   79.56%   79.59%   +0.02%     
==========================================
  Files         140      140              
  Lines       15581    15581              
  Branches     2643     2643              
==========================================
+ Hits        12397    12401       +4     
+ Misses       2345     2343       -2     
+ Partials      839      837       -2
Files with missing lines Coverage Δ
sentry_sdk/integrations/starlette.py 84.09% <66.66%> (ø)

... and 3 files with indirect coverage changes

szokeasaurusrex
szokeasaurusrex reviewed Mar 5, 2025
View reviewed changes
@antonpirker antonpirker merged commit 7deebf0 into master Mar 10, 2025
141 of 142 checks passed
@antonpirker antonpirker deleted the antonpirker/fix/fastapi-middleware branch March 10, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szokeasaurusrex szokeasaurusrex szokeasaurusrex left review comments

@sentrivana sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError when instantiating Starlette middleware with positional arguments

4 participants

@antonpirker @szokeasaurusrex @sentrivana